Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run actionlint as a pre-merge check. #104

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Run actionlint as a pre-merge check. #104

merged 2 commits into from
Jul 8, 2024

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Jul 8, 2024

Add actionlint as a pre-merge check.

Not mandatory for now, because GitHub still doesn't support the "check must succeed if it runs" use case, so making it mandatory means we'd have to run it on pushes that don't touch any relevant files, which is just silly.

Fix existing lints so it's clean for now.

alphagov/govuk-infrastructure#1361

sengi added 2 commits July 8, 2024 16:59
Not mandatory for now, at least while I fix existing lints.
@sengi sengi force-pushed the sengi/actionlint2 branch from 6d0d83a to 3702c10 Compare July 8, 2024 15:59
@sengi sengi requested a review from theseanything July 8, 2024 16:00
@sengi sengi marked this pull request as ready for review July 8, 2024 16:00
@sengi sengi merged commit da1e938 into main Jul 8, 2024
3 checks passed
@sengi sengi deleted the sengi/actionlint2 branch July 8, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants