Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback component accessibility fix #3930

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Feedback component accessibility fix #3930

wants to merge 8 commits into from

Commits on Mar 18, 2024

  1. Remove cancel button

    @JamesCGDS
    JamesCGDS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b84c9e6 View commit details
    Browse the repository at this point in the history

  2. Use single button for toggling feedback forms

    @JamesCGDS
    JamesCGDS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    4490e8f View commit details
    Browse the repository at this point in the history

  3. Add styles for toggling feedback prompts

    @JamesCGDS
    JamesCGDS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    bb74e99 View commit details
    Browse the repository at this point in the history

  4. Add JS for toggling feedback prompts

    @JamesCGDS
    JamesCGDS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    221788f View commit details
    Browse the repository at this point in the history

  5. Focus on form control buttons whenever feedback forms are closed

    @JamesCGDS
    JamesCGDS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    22aa1e8 View commit details
    Browse the repository at this point in the history

  6. Toggle data attributes depending on expansion/collapse

    @JamesCGDS
    JamesCGDS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5589ec3 View commit details
    Browse the repository at this point in the history

  7. Move trackEvent above toggleForm 

    This is to prevent trackEvent from running too early as toggleForms now amends data attributes on expansion/collapse
    @JamesCGDS
    JamesCGDS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    262fef6 View commit details
    Browse the repository at this point in the history

  8. Fix/add tests

    @JamesCGDS
    JamesCGDS committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d5a91b3 View commit details
    Browse the repository at this point in the history