Tidy unused CSS in layout super navigation component #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csutter
changed the title
csutter
force-pushed
the
super-nav-tidy
branch
from
b86c704
to
187a716
Compare
- Remove unused styles from previous iterations of the markup that haven't been removed - Remove unnecessarily convoluted selector targetting element `.gem-c-layout-super-navigation-header__navigation-top-toggle-button` both with and without `--blue-background` modifier - Move open state logic into main `top-toggle-button` block
csutter
force-pushed
the
super-nav-tidy
branch
from
187a716
to
0cf8f23
Compare
MartinJJones
reviewed
Oct 8, 2024
| } | ||
|
|
||
| .gem-c-layout-super-navigation-header__navigation-top-toggle-button.gem-c-layout-super-navigation-header__navigation-top-toggle-button--blue-background, | ||
| .gem-c-layout-super-navigation-header__navigation-top-toggle-button { |
There was a problem hiding this comment.
It does make sense to remove this to me, but when testing the blue background variation of the component on Safari for iOS it will cause the "Menu" text for the button to appear white instead of blue when clicked, for example:
Likely several ways to solve this, possibly re-ordering the CSS to help set the expected precedence to avoid adding further CSS. This could take a bit of work and likely out of scope for the original intended purpose of code cleanup in the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
This PR moves a lot of code around blocks and is best viewed with whitespace changes ignored (
?w=1)What
Removes some cruft from the layout super navigation header component.
Why
Removing code sparks joy. Also as a stepping stone to help us change the search menu to a new design in a future PR.
Visual Changes
None.