Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new chart component options #4318

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Add new chart component options #4318

merged 6 commits into from
Oct 22, 2024
+246 −73

Commits on Oct 22, 2024

  1. Add minimal option to chart component

    @andysellick
    andysellick committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5ade6be View commit details
    Browse the repository at this point in the history

  2. Add option for chart height 

    - currently hard coded as the chart isn't responsive
- quite difficult to write a test for this as it's applied as an inline style
    @andysellick
    andysellick committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9f5ed5b View commit details
    Browse the repository at this point in the history

  3. Make Google charts script load only once 

    - use an Openstruct to persist a value between multiple instances of the component to make the external script for Google charts only be called once
- perhaps unsurprisingly this doesn't make any difference to the page weight in Chrome, presumably because Chrome is smart enough to realise it's already loaded that script if there's more than one chart
- however it feels tidier to limit it this way, particularly for browsers that may not be so clever
    @andysellick
    andysellick committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f8cc2ed View commit details
    Browse the repository at this point in the history

  4. Use Rails validation to check minimal configuration

    @andysellick
    andysellick committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    357afbd View commit details
    Browse the repository at this point in the history

  5. Improve link accessibility 

    - improve focus state around link to have a complete border and be more visible
- use aria hidden on the graph when in minimal mode
    @andysellick
    andysellick committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    cc9ccf5 View commit details
    Browse the repository at this point in the history

  6. Update changelog

    @andysellick
    andysellick committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e4417df View commit details
    Browse the repository at this point in the history