Update all references to deprecated Rails.applications.secrets to Rai…

…ls.application.credentials
alphagov · Oct 31, 2023 · a064968 · a064968
1 parent d5acefe
commit a064968
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/app/controllers/webhooks_controller.rb b/app/controllers/webhooks_controller.rb
@@ -17,7 +17,7 @@ def link_check_callback
 private
 
   def verify_signature
-    return unless Rails.application.secrets.link_checker_api_secret_token
+    return unless Rails.application.credentials.link_checker_api_secret_token
 
     given_signature = request.headers["X-LinkCheckerApi-Signature"]
     return head :bad_request unless given_signature
@@ -28,6 +28,6 @@ def verify_signature
   end
 
   def webhook_secret_token
-    Rails.application.secrets.link_checker_api_secret_token
+    Rails.application.credentials.link_checker_api_secret_token
   end
 end
diff --git a/app/lib/local_links_manager/check_links/link_status_requester.rb b/app/lib/local_links_manager/check_links/link_status_requester.rb
@@ -44,7 +44,7 @@ def webhook_uri
       end
 
       def webhook_secret_token
-        Rails.application.secrets.link_checker_api_secret_token
+        Rails.application.credentials.link_checker_api_secret_token
       end
 
       def link_checker_api

diff --git a/spec/lib/local-links-manager/check_links/link_status_requester_spec.rb b/spec/lib/local-links-manager/check_links/link_status_requester_spec.rb
@@ -17,19 +17,19 @@
       stub1 = stub_link_checker_api_create_batch(
         uris: [link1.url],
         webhook_uri: "http://local-links-manager.dev.gov.uk/link-check-callback",
-        webhook_secret_token: Rails.application.secrets.link_checker_api_secret_token,
+        webhook_secret_token: Rails.application.credentials.link_checker_api_secret_token,
       )
 
       stub2 = stub_link_checker_api_create_batch(
         uris: [link2.url],
         webhook_uri: "http://local-links-manager.dev.gov.uk/link-check-callback",
-        webhook_secret_token: Rails.application.secrets.link_checker_api_secret_token,
+        webhook_secret_token: Rails.application.credentials.link_checker_api_secret_token,
       )
 
       stub3 = stub_link_checker_api_create_batch(
         uris: [local_authority1.homepage_url, local_authority2.homepage_url],
         webhook_uri: "http://local-links-manager.dev.gov.uk/link-check-callback",
-        webhook_secret_token: Rails.application.secrets.link_checker_api_secret_token,
+        webhook_secret_token: Rails.application.credentials.link_checker_api_secret_token,
       )
 
       link_status_requester.call
@@ -47,13 +47,13 @@
       homepage_stub = stub_link_checker_api_create_batch(
         uris: [disabled_service_link.local_authority.homepage_url],
         webhook_uri: "http://local-links-manager.dev.gov.uk/link-check-callback",
-        webhook_secret_token: Rails.application.secrets.link_checker_api_secret_token,
+        webhook_secret_token: Rails.application.credentials.link_checker_api_secret_token,
       )
 
       homepage_and_link_stub = stub_link_checker_api_create_batch(
         uris: [disabled_service_link.url, disabled_service_link.local_authority.homepage_url],
         webhook_uri: "http://local-links-manager.dev.gov.uk/link-check-callback",
-        webhook_secret_token: Rails.application.secrets.link_checker_api_secret_token,
+        webhook_secret_token: Rails.application.credentials.link_checker_api_secret_token,
       )
 
       link_status_requester.call
@@ -72,7 +72,7 @@
       stub1 = stub_link_checker_api_create_batch(
         uris: [link1.url, local_authority1.homepage_url],
         webhook_uri: "http://local-links-manager.dev.gov.uk/link-check-callback",
-        webhook_secret_token: Rails.application.secrets.link_checker_api_secret_token,
+        webhook_secret_token: Rails.application.credentials.link_checker_api_secret_token,
       )
 
       link_status_requester.check_authority_urls "ambridge"

diff --git a/spec/requests/link_checker_api_spec.rb b/spec/requests/link_checker_api_spec.rb
@@ -7,7 +7,7 @@
   subject(:status_updater) { described_class.new }
 
   def webhook_secret_token
-    Rails.application.secrets.link_checker_api_secret_token
+    Rails.application.credentials.link_checker_api_secret_token
   end
 
   def generate_signature(body)