Redirect all-caps article slugs to lowercase. #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move this redirect functionality from nginx into Router, so that we can
finally drop Perl from the nginx config.
We'll need to push this further down into the backend ("frontend") apps
when we get rid of Router, but there's still value in eliminating Perl
from the request path sooner rather than later.
- Use the conventional `r` and `w` short names for http.Request and http.ResponseWriter parameters. - Factor out ghttp.Server declaration. - Push recorderURL down into the only test case that uses it. - Fix missing err check on a call to URL.Parse(). No functional change (apart from the missing err check), just readability.
sengi
force-pushed
the
sengi/lowercase
branch
from
0a0b1a0 to
a37389c
Compare
|
Thanks @sihugh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move this redirect functionality from nginx into Router, so that we can finally drop Perl from the nginx config.
We'll need to push this further down into the backend ("frontend") apps when we get rid of Router, but there's still value in eliminating Perl from the request path sooner rather than later.
Also some trivial style cleanup in proxy_function integration tests.