Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users page improvements #2392

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Users page improvements #2392

merged 2 commits into from
Sep 29, 2023

Conversation

chrislo
Copy link
Contributor

@chrislo chrislo commented Sep 28, 2023

Trello: https://trello.com/c/zNFNt7Oj

Two small improvements to the /users index page:

  • using a secondary quiet button for "upload a batch of users"
  • removing the 2SV <abbr> tag in the table header

@chrislo chrislo force-pushed the users-page-improvements branch from 2221900 to 1cd635f Compare September 29, 2023 09:11
@chrislo chrislo marked this pull request as ready for review September 29, 2023 09:11
@floehopper floehopper self-assigned this Sep 29, 2023
Copy link
Contributor

@floehopper floehopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

We identified this change during a design review.
Using <abbr> isn't consistent with the design system so we're removing
it.
@chrislo chrislo force-pushed the users-page-improvements branch from 1cd635f to 1c820d9 Compare September 29, 2023 13:05
@chrislo
Copy link
Contributor Author

chrislo commented Sep 29, 2023

Thanks @floehopper! Rebasing on main before merging.

@chrislo chrislo merged commit a6f9ce2 into main Sep 29, 2023
6 checks passed
@chrislo chrislo deleted the users-page-improvements branch September 29, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants