Prevent duplicate rows in /users when filters applied #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislo
force-pushed
the
fix-duplicate-user-bug-in-users-filter
branch
from
d076882 to
552fefd
Compare
chrislo
changed the title
chrislo
force-pushed
the
fix-duplicate-user-bug-in-users-filter
branch
from
552fefd to
d98a52d
Compare
floehopper
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Good work! LGTM 👍
One minor thing - the test names suggest that the problem is specific to multiple permissions on the SAME app, but the commit note / PR description doesn't mention that. I'm guessing that's just an omission in the commit note / PR description, but either way it would be nice to bring the two things into line.
|
Thanks @floehopper! I'll clarify that in the commit note before merging. |
Trello: https://trello.com/c/i27MQaus This fixes an issue with duplication of a user in the table on /users (and the corresponding CSV export) when multiple permissions for the same application were selected in the filter. For example if a user had the "GDS editor" and "signon" permission for the "Transition" app and we selected both of those permissions in the filter drop down, this user would appear twice in table. The solution is to call `distinct` on the `User#with_permission` scope, which is in turn called by `UsersFilter#users`. I've decided to add a test case in both places to avoid a regression in `UsersFilter` in case it changes in the future. Note we have to add the `unscoped` method to `SupportedPermission` in the `User#with_permission` scope since `SupportedPermission` has an `order(:name)` `default_scope` and calling `distinct` on an order query is not supported by MySQL: Mysql2::Error: Expression #1 of ORDER BY clause is not in SELECT list, references column 'signon_test.supported_permissions.name' which is not in SELECT list; this is incompatible with DISTINCT
chrislo
force-pushed
the
fix-duplicate-user-bug-in-users-filter
branch
from
d98a52d to
b4b0f5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/i27MQaus
This fixes an issue with duplication of a user in the table on /users (and the corresponding CSV export) when multiple permissions for the same application were selected in the filter.
For example if a user had the "GDS editor" and "signon" permission for the "Transition" app and we selected both of those permissions in the filter drop down, this user would appear twice in table.
The solution is to call
distincton theUser#with_permissionscope, which is in turn called byUsersFilter#users. I've decided to add a test case in both places to avoid a regression inUsersFilterin case it changes in the future.Note we have to add the
unscopedmethod toSupportedPermissionin theUser#with_permissionscope sinceSupportedPermissionhas anorder(:name)default_scopeand callingdistincton an ordered query is not supported by MySQL: