Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github.event.release.tag_name in Deploy workflow #2421

Merged

Conversation

chrisroos
Copy link
Contributor

We've been experiencing intermittent failures in this workflow that appear to be caused by github.ref_name being empty. Other teams in GDS have been experiencing the same problem.

@theseanything has been in contact with GitHub support and received the following reply:

We have an open internal issue where our engineers are investigating
the intermittent unavailability of github.ref_name context when
workflow runs are triggered on release events. I have added your report
to the investigation. We also have an open community discussion on
this, You can add your voice to this. See below:
actions/runner#2788 As a workaround, could you
try using github.event.release.tag_name instead, as this is the
preferred method for referencing the tag name of a release. See more
details on this github.event context in the github context list below:
https://docs.github.com/en/enterprise-cloud@latest/actions/learn-github-actions/contexts#github-context

Hopefully we'll see fewer of these intermittent deploy failures with this change in place.

We've been experiencing intermittent failures in this workflow that
appear to be caused by `github.ref_name` being empty. Other teams in GDS
have been experiencing the same problem[1].

@theseanything has been in contact with GitHub support and received the
following reply:

> We have an open internal issue where our engineers are investigating
> the intermittent unavailability of `github.ref_name` context when
> workflow runs are triggered on release events. I have added your report
> to the investigation.  We also have an open community discussion on
> this, You can add your voice to this. See below:
> actions/runner#2788 As a workaround, could you
> try using `github.event.release.tag_name` instead, as this is the
> preferred method for referencing the tag name of a release.  See more
> details on this `github.event` context in the github context list below:
> https://docs.github.com/en/enterprise-cloud@latest/actions/learn-github-actions/contexts#github-context

Hopefully we'll see fewer of these intermittent deploy failures with
this change in place.

[1]: https://gds.slack.com/archives/C013F737737/p1693313259502869
@chrisroos
Copy link
Contributor Author

Thanks @theseanything 👍

@chrisroos chrisroos enabled auto-merge October 10, 2023 12:08
@chrisroos chrisroos merged commit 879456d into main Oct 10, 2023
7 checks passed
@chrisroos chrisroos deleted the use-github-event-release-tag-name-in-deploy-workflow branch October 10, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants