Make applications table vertical on small screens #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
force-pushed
the
use-vertical-layout-on-applications-table
branch
from
0625309 to
a27dea6
Compare
yndajas
force-pushed
the
fix-applications-table-actions-column
branch
from
cdb506e to
fa48f49
Compare
yndajas
force-pushed
the
use-vertical-layout-on-applications-table
branch
from
a27dea6 to
9ade5af
Compare
yndajas
force-pushed
the
use-vertical-layout-on-applications-table
branch
from
9ade5af to
8524a17
Compare
yndajas
changed the base branch from
fix-applications-table-actions-column
to
fix-test-comment
yndajas
force-pushed
the
use-vertical-layout-on-applications-table
branch
from
8524a17 to
1bc95f4
Compare
Since #2341, we've had support for making tables use a vertical layout on smaller viewports, similar to how the summary list reflows on smaller viewports (the end result is something of a hybrid of table and summary list layouts) We already use this on the users screen. This feels like something that would be useful on the applications screen too I've added an optional `visually_hidden` flag on table head cells here, which when set to `true` will result in a class that removes padding from the header cell. The current actions column on the applications page has a visually hidden header, so this allows us to remove the padding from visually hidden header cells while retaining the content Per f0a8f53, we switch to regex-based matching for some tests. The vertical layout implementation adds some hidden text in table cells that would otherwise break these `assert_select`s
These are useful for testing out applications page layouts with more realistic length data
yndajas
force-pushed
the
use-vertical-layout-on-applications-table
branch
from
1bc95f4 to
0404d75
Compare
callumknights
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
Since #2341, we've had support for making tables use a vertical layout on smaller viewports, similar to how the summary list reflows on smaller viewports (the end result is something of a hybrid of table and summary list layouts)
We already use this on the users screen. This feels like something that would be useful on the applications screen too
Screenshots
Medium screen
Before
After
Small screen
Before
After
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.