Bump rubocop-govuk from 4.12.0 to 4.13.0 #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
Follow these steps if you are doing a Rails upgrade. |
govuk-ci
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
This PR has been scanned and automatically approved by govuk-dependabot-merger.
ChrisBAshton
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
This PR has been scanned and automatically approved by govuk-dependabot-merger
It shouldn't have. Now fixed in alphagov/govuk-dependabot-merger#30
ChrisBAshton
added a commit
to alphagov/govuk-dependabot-merger
that referenced
this pull request
Dec 27, 2023
For a long time, GOV.UK had a convention whereby repositories had to specify a status check called 'test', which should be the name of the CI job that runs a repo's tests, linter, and so on. These would all run under the 'test' job, usually via something like `bundle exec rake`. In January 2023, a [new convention](alphagov/content-data-admin@89a888b) was established, whereby there would now be an overall workflow called 'CI'. Within this workflow, there would be several individual jobs, each with their own responsibility (e.g. 'test-ruby' for running tests, 'lint-ruby' for running the linter, and so on). We should therefore no longer look for a 'test' job: the modern equivalent is to check for the 'CI' workflow, and to validate that every job within the CI workflow passes. Note that as a [stopgap](#21), we temporarily stopped looking for a 'test' job and switched to looking for a 'test-ruby' job instead. This is suboptimal as it only checks for the outcome of the unit tests, and doesn't consider other checks such as the linter, so it will incorrectly [try and fail to approve and merge](alphagov/support-api#870 (review)) PRs whose unit tests pass but where there is another check failing.
ChrisBAshton
added a commit
to alphagov/govuk-dependabot-merger
that referenced
this pull request
Dec 27, 2023
For a long time, GOV.UK had a convention whereby repositories had to specify a status check called 'test', which should be the name of the CI job that runs a repo's tests, linter, and so on. These would all run under the 'test' job, usually via something like `bundle exec rake`. In January 2023, a [new convention](alphagov/content-data-admin@89a888b) was established, whereby there would now be an overall workflow called 'CI'. Within this workflow, there would be several individual jobs, each with their own responsibility (e.g. 'test-ruby' for running tests, 'lint-ruby' for running the linter, and so on). We should therefore no longer look for a 'test' job: the modern equivalent is to check for the 'CI' workflow, and to validate that every job within the CI workflow passes. Note that as a [stopgap](#21), we temporarily stopped looking for a 'test' job and switched to looking for a 'test-ruby' job instead. This is suboptimal as it only checks for the outcome of the unit tests, and doesn't consider other checks such as the linter, so it will incorrectly [try and fail to approve and merge](alphagov/support-api#870 (review)) PRs whose unit tests pass but where there is another check failing.
AgaDufrat
force-pushed
the
dependabot/bundler/rubocop-govuk-4.13.0
branch
7 times, most recently
from
863d48f to
4f43247
Compare
Bumps [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) from 4.12.0 to 4.13.0. - [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md) - [Commits](alphagov/rubocop-govuk@v4.12.0...v4.13.0) --- updated-dependencies: - dependency-name: rubocop-govuk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
ChrisBAshton
force-pushed
the
dependabot/bundler/rubocop-govuk-4.13.0
branch
from
4f43247 to
dafdfd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop-govuk from 4.12.0 to 4.13.0.
Changelog
Sourced from rubocop-govuk's changelog.
Commits
51e44aeMerge pull request #338 from alphagov/bump-version2bf3ab8Bump to 4.13.052de757Merge pull request #337 from alphagov/dependabot/bundler/rubocop-rails-eq-2.23.096b74afUpdate rubocop-rails requirement from = 2.22.2 to = 2.23.049bf3f3Merge pull request #336 from alphagov/dependabot/bundler/rubocop-eq-1.59.0210aac4Update rubocop requirement from = 1.58.0 to = 1.59.0bdfbeefMerge pull request #335 from alphagov/dependabot/bundler/rubocop-eq-1.58.03e7dd46Update rubocop requirement from = 1.57.2 to = 1.58.0c9cf9eeMerge pull request #334 from alphagov/add-sca-sast-scansad93f12Add CodeQL (SAST) scan and Dependency Review (SCA) scan to CI pipelineDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)