Simplifying logic of asset checking

Instead of relying on splitting, we could just use the filename that we actually pass through to asset manager to do the checks

app/models/call_for_evidence_response_form_data.rb

@@ -27,8 +27,6 @@ def filename
   end
 
   def assets_match_updated_image_filename
-    return false unless carrierwave_file
-
-    assets.all? { |asset| asset.filename.include?(carrierwave_file.split("/").last) }
+    assets.all? { |asset| asset.filename.include?(filename) } if filename
   end
 end

app/models/consultation_response_form_data.rb

@@ -26,8 +26,6 @@ def filename
   end
 
   def assets_match_updated_image_filename
-    return false unless carrierwave_file
-
-    assets.all? { |asset| asset.filename.include?(carrierwave_file.split("/").last) }
+    assets.all? { |asset| asset.filename.include?(filename) } if filename
   end
 end

app/models/featured_image_data.rb

@@ -40,8 +40,6 @@ def republish_on_assets_ready
 private
 
   def assets_match_updated_image_filename
-    return false unless carrierwave_image
-
-    assets.all? { |asset| asset.filename.include?(carrierwave_image.split("/").last) }
+    assets.all? { |asset| asset.filename.include?(filename) } if filename
   end
 end

app/models/promotional_feature_item.rb

@@ -65,8 +65,6 @@ def republish_organisation
   end
 
   def assets_match_updated_image_filename
-    return false unless self[:image]
-
-    assets.all? { |asset| asset.filename.include?(self[:image].split("/").last) }
+    assets.all? { |asset| asset.filename.include?(self[:image]) } if self[:image]
   end
 end

test/unit/app/models/call_for_evidence_response_form_data_test.rb

@@ -73,8 +73,8 @@ class CallForEvidenceResponseFormDataTest < ActiveSupport::TestCase
     call_for_evidence_response_form_data.update!(
       call_for_evidence_response_form_data.attributes.merge(
         file: upload_fixture("copy:#{call_for_evidence_response_form_data.filename}"),
-        ),
-      )
+      ),
+    )
 
     assert_not call_for_evidence_response_form_data.all_asset_variants_uploaded?
   end