Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content-modelling/ show only one edit action for content blocks #9632

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

Harriethw
Copy link
Contributor

@Harriethw Harriethw commented Nov 19, 2024

to match the agreed UI design

https://trello.com/c/HXLqncRg/648-update-check-your-answers-page
I'm keeping this scope to just the edit button and the existing check your answers page - as this PR has dragged on a bit I think any further content tweaks (e.g. to copy of button etc.) could be picked up later. Based on designs currently in Figma.

Screenshot 2024-11-21 at 11 56 24

Screenshot 2024-11-21 at 12 32 21

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@Harriethw Harriethw changed the title show only one edit action for content blocks content-modelling/ show only one edit action for content blocks Nov 19, 2024
Copy link
Contributor

@pezholio pezholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the design had a title for the Block Type, followed by an edit button as per:

image

@Harriethw Harriethw force-pushed the content-modelling/648-edit-button branch 3 times, most recently from 68eaf06 to eef4280 Compare November 20, 2024 17:33
@Harriethw Harriethw marked this pull request as draft November 20, 2024 17:33
users should be able to go back and edit
their answers from the 'check your answers'
page in the new edition journey.
show just one edit action according to design
@Harriethw Harriethw force-pushed the content-modelling/648-edit-button branch from eef4280 to dab172a Compare November 21, 2024 11:54
@Harriethw Harriethw force-pushed the content-modelling/648-edit-button branch from dab172a to a3403f8 Compare November 21, 2024 12:31
@Harriethw Harriethw marked this pull request as ready for review November 21, 2024 13:54
Copy link
Contributor

@pezholio pezholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for bearing with this! 😅

@Harriethw Harriethw merged commit bf51825 into main Nov 21, 2024
19 checks passed
@Harriethw Harriethw deleted the content-modelling/648-edit-button branch November 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants