-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content modelling/659 Preview Host Documents via iFrame #9640
Open
Harriethw
wants to merge
8
commits into
main
Choose a base branch
from
content-modelling/659-preview-with-embedded
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 25, 2024
-
add service to get html for host document preview
calls the gov.uk frontend to get the raw HTML of the page in the future we could find the embedded content block inside that HTML and transform it.
Configuration menu - View commit details
-
Copy full SHA for 2246670 - Browse repository at this point
Copy the full SHA 2246670View commit details -
sp that we can use this id to get the preview HTML
Configuration menu - View commit details
-
Copy full SHA for 99de250 - Browse repository at this point
Copy the full SHA 99de250View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64b3a80 - Browse repository at this point
Copy the full SHA 64b3a80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f5d64f - Browse repository at this point
Copy the full SHA 4f5d64fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 996cf00 - Browse repository at this point
Copy the full SHA 996cf00View commit details -
replace existing content block with one under preview
here we iterate through the snapshot of HTML from the frontend, and find the `<span>` containing the existing edition of the Content Block we are previewing. We then replace it with the `render` output of the content block we are currently previewing.
Configuration menu - View commit details
-
Copy full SHA for a7a8ef4 - Browse repository at this point
Copy the full SHA a7a8ef4View commit details -
provisionally style preview of content blocks
a minimal styling to help us see the changed blocks in the build - TBC on actual UI design.
Configuration menu - View commit details
-
Copy full SHA for bab3030 - Browse repository at this point
Copy the full SHA bab3030View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a7cd8f - Browse repository at this point
Copy the full SHA 5a7cd8fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.