Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate add another usage to govuk_publishing_components impementation #9644

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Migrate add another usage to govuk_publishing_components impementation #9644

wants to merge 6 commits into from
+212 −570

Conversation

dnkrj
Copy link
Contributor

@dnkrj dnkrj commented Nov 22, 2024 •
edited
Loading

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

  • Migrate the 5 usages of the add-another pattern in Whitehall to the the govuk_publishing_components implementation introduced in govuk_publishing_components/pull/4420

Why

Screenshots

Before After
whitehall-admin integration publishing service gov uk_government_admin_organisations_government-digital-service_edit(iPad Pro) whitehall-admin dev gov uk_government_admin_organisations_government-digital-service_edit(iPad Pro)

@dnkrj
Delete add-another module
0f815aa 
This has been moved to `govuk_publishing_components` so no longer needs to be defined in Whitehall.
ryanb-gds
ryanb-gds approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@ryanb-gds ryanb-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the items passed to the add another component aren't hugely readable - I wonder if we might make use of some intermediate variables to build the items before we pass them to the components. Definitely not a show stopper though

@dnkrj
Migrate contact numbers to new add-another
73877e0 
Call the new publishing components add another template for contact numbers
@dnkrj
Migrate casualties to new add-another
9da0d91 
Call the new publishing components add another template for casualties
@dnkrj
Migrate social media accounts to new add-another
b0b9808 
Call the new publishing components add another template for social media accounts
@dnkrj
Migrate featured links to new add-another
9ee34af 
Call the new publishing components add another template for featured links
@dnkrj
Migrate promotional feature links to new add-another
bbbe8a4 
Call the new publishing components add another template for promotional feature links
@dnkrj dnkrj force-pushed the 3139-move-add-another-pattern-to-govukpublishingcomponents branch from 884068c to bbbe8a4 Compare November 25, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanb-gds ryanb-gds ryanb-gds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnkrj @ryanb-gds