Organisation description fix #9648
Merged
+40
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove trailing spaces
When there are organisations with a parent and also multiple children, we need to make the description grammatically correct. At the moment it says "org 1 works with org 2 is supported by 3....". Appending "and" to make the sentence read better.
minhngocd
force-pushed
the
organisation-description-fix
branch
from
3c6370b
to
c2cf7d4
Compare
ryanb-gds
approved these changes
Nov 25, 2024
+1 to that - maybe we stick something in tech debt... I was also expecting to put the fix into the rendering app but when traced back, it was attached to the content item all along... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZenDesk enquiry to fix up some copy of Organisation descriptions.
https://trello.com/c/oLQQId8c/3195-technical-fault-with-whitehall
Follow these steps if you are doing a Rails upgrade.