check if auth data exists before using

altair-graphql · Jul 8, 2024 · 493b56f · 493b56f
1 parent ddd1634
commit 493b56f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/packages/altair-core/src/authorization/authorization-provider.ts b/packages/altair-core/src/authorization/authorization-provider.ts
@@ -2,7 +2,7 @@ import { AuthorizationResult } from '../types/state/authorization.interface';
 
 export interface AuthorizationProviderExecuteOptions<T = unknown> {
   // The input from the user
-  data: T;
+  data: T | undefined;
 }
 
 export abstract class AuthorizationProvider<T = unknown> {

diff --git a/packages/altair-core/src/authorization/providers/basic.ts b/packages/altair-core/src/authorization/providers/basic.ts
@@ -12,7 +12,7 @@ export default class BasicAuthorizationProvider extends AuthorizationProvider<Ba
   async execute(
     options: AuthorizationProviderExecuteOptions<BasicAuthorizationProviderData>
   ): Promise<AuthorizationResult> {
-    if (!options.data.username || !options.data.password) {
+    if (!options.data?.username || !options.data?.password) {
       return {
         headers: {},
       };

diff --git a/packages/altair-core/src/authorization/providers/bearer.ts b/packages/altair-core/src/authorization/providers/bearer.ts
@@ -11,6 +11,11 @@ export default class BearerAuthorizationProvider extends AuthorizationProvider<B
   async execute(
     options: AuthorizationProviderExecuteOptions<BearerAuthorizationProviderData>
   ): Promise<AuthorizationResult> {
+    if (!options.data?.token) {
+      return {
+        headers: {},
+      };
+    }
     return {
       headers: {
         Authorization: `Bearer ${this.hydrate(options.data.token)}`,

diff --git a/packages/altair-core/src/authorization/providers/oauth2.ts b/packages/altair-core/src/authorization/providers/oauth2.ts
@@ -12,6 +12,11 @@ export default class OAuth2AuthorizationProvider extends AuthorizationProvider<O
   async execute(
     options: AuthorizationProviderExecuteOptions<OAuth2AuthorizationProviderData>
   ): Promise<AuthorizationResult> {
+    if (!options.data?.accessTokenResponse) {
+      return {
+        headers: {},
+      };
+    }
     return {
       headers: {
         Authorization: `Bearer ${this.hydrate(options.data.accessTokenResponse.access_token)}`,