event emitters tests in action_bar component #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry @imolorhe that these did not work the first time. I am first time contributor. I looked closely at tests for other components and modeled mine after those. Please let me know if they still are incorrect. |
|
@imolorhe Is there anything else I need to do for this PR? |
imolorhe
requested changes
Jan 27, 2024
There was a problem hiding this comment.
Sorry some tests are still failing https://github.com/altair-graphql/altair/actions/runs/7674181736/job/20919231287?pr=2411
|
@imolorhe sorry for the back and forth but the errors should be fixed now. I updated the snapshot to reflect the classes I added in the html and I moved a class that I accidentally put in an inaccurate spot. The two failing tests should be resolved now. |
imolorhe
approved these changes
Jan 27, 2024
Merged
via the queue into
altair-graphql:master
with commit Jan 27, 2024
e33bec3
7 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This PR helps fix issue #1717 which is an ongoing issue that requests more tests for components in altair-app.
Checks
Ran yarn test-build
Updated relevant documentations
Updated matching config options in altair-static
Changes proposed in this pull request:
I added tests for the event_emitters for the action_bar component to make sure they go off properly.