-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to angular v18 #2739
update to angular v18 #2739
Conversation
Reviewer's Guide by SourceryThis PR updates the Angular framework from version 17 to version 18.2.13, along with related dependencies. The implementation includes necessary code adjustments to accommodate Angular's new HTTP client provider pattern and general cleanup of module configurations. Class diagram for updated Angular module configurationclassDiagram
class AltairModule {
+AltairComponent[] bootstrap
+CUSTOM_ELEMENTS_SCHEMA[] schemas
+AltairComponent[] exports
+providers[]
+constructor()
}
class AltairComponent
class WindowComponent
class BrowserModule
class BrowserAnimationsModule
class FormsModule
class ReactiveFormsModule
class SharedModule {
+forRoot()
}
class ComponentModule
class DocViewerModule
class provideHttpClient {
+withInterceptorsFromDi()
}
AltairModule --> AltairComponent
AltairModule --> WindowComponent
AltairModule --> BrowserModule
AltairModule --> BrowserAnimationsModule
AltairModule --> FormsModule
AltairModule --> ReactiveFormsModule
AltairModule --> SharedModule
AltairModule --> ComponentModule
AltairModule --> DocViewerModule
AltairModule --> provideHttpClient
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imolorhe - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR checklist to confirm that tests have been run and documentation has been updated.
- For a major Angular version upgrade (17 -> 18), please document any breaking changes and required migration steps in the PR description.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Visit the preview URL for this PR (updated for commit 8168e54): https://altair-gql--pr2739-imolorhe-update-angu-p6aqweh3.web.app (expires Sun, 22 Dec 2024 00:40:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 02d6323d75a99e532a38922862e269d63351a6cf |
Fixes
Checks
yarn test-build
Changes proposed in this pull request:
Summary by Sourcery
Upgrade the project to Angular version 18 and refactor test setups to use 'provideHttpClient' with interceptors from DI. Update the Angular CLI configuration to use 'pnpm' as the package manager.
Enhancements:
Build: