-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload schema on environment change #2742
Conversation
Reviewer's Guide by SourceryThis PR implements automatic schema reloading when switching environments. The implementation adds a new setting 'schema.reload.onEnvChange' and uses Redux selectors to trigger schema reloads when the environment changes and the setting is enabled. Sequence diagram for schema reload on environment changesequenceDiagram
participant User
participant Store
participant WindowComponent
participant ReduxSelector
User->>Store: Change environment
Store->>ReduxSelector: Check 'schema.reload.onEnvChange' setting
ReduxSelector-->>WindowComponent: Return activeEnvironment if reloadOnChange is true
alt activeEnvironment is not null
WindowComponent->>WindowComponent: reloadDocs()
end
Updated class diagram for SettingsState interfaceclassDiagram
class SettingsState {
+boolean schema.reloadOnStart
+boolean schema.reload.onEnvChange
+boolean disableUpdateNotification
}
note for SettingsState "Added 'schema.reload.onEnvChange' attribute"
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imolorhe - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please update the documentation to describe the new
schema.reload.onEnvChange
setting and its functionality.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Visit the preview URL for this PR (updated for commit f0d911b): https://altair-gql--pr2742-imolorhe-reload-sche-jvvz7alr.web.app (expires Sun, 22 Dec 2024 18:07:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 02d6323d75a99e532a38922862e269d63351a6cf |
Fixes
#2733
Checks
yarn test-build
Changes proposed in this pull request:
Summary by Sourcery
Implement automatic schema reloading when the environment changes by adding a new setting 'schema.reload.onEnvChange'. Update the test-server package.json to specify yarn as the package manager.
New Features:
Enhancements:
Build: