[update]

alvo254 · Jun 10, 2024 · dce891f · dce891f
1 parent 1d24512
commit dce891f
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 25 deletions.
diff --git a/modules/ecs/container_definitions.json b/modules/ecs/container_definitions.json
@@ -1,24 +1,17 @@
-{
-  "family": "app",
-  "networkMode": "awsvpc",
-  "requiresCompatibilities": ["FARGATE"],
-  "executionRoleArn": "arn:aws:iam::your_account_id:role/ecsExecRole",
-  "cpu": "256",
-  "memory": "512",
-  "containerDefinitions": [
-    {
-      "name": "app",
-      "image": "alvin254/fitnesshero",
-      "cpu": 256,
-      "memory": 512,
-      "essential": true,
-      "portMappings": [
-        {
-          "containerPort": 3000,
-          "hostPort": 3000,
-          "protocol": "tcp"
-        }
-      ]
-    }
-  ]
-}
+[
+  {
+    "name": "app",
+    "image": "alvin254/fitnesshero",
+    "cpu": 256,
+    "memory": 512,
+    "essential": true,
+    "portMappings": [
+      {
+        "containerPort": 3000,
+        "hostPort": 3000,
+        "protocol": "tcp"
+      }
+    ]
+  }
+]
+
diff --git a/modules/ecs/main.tf b/modules/ecs/main.tf
@@ -59,4 +59,29 @@ resource "aws_ecs_service" "app_service" {
     security_groups = [var.security_group]
     assign_public_ip = true
   }
-}
+}
+
+// {
+//   "family": "app",
+//   "networkMode": "awsvpc",
+//   "requiresCompatibilities": ["FARGATE"],
+//   "executionRoleArn": "arn:aws:iam::your_account_id:role/ecsExecRole",
+//   "cpu": "256",
+//   "memory": "512",
+//   "containerDefinitions": [
+//     {
+//       "name": "app",
+//       "image": "alvin254/fitnesshero",
+//       "cpu": 256,
+//       "memory": 512,
+//       "essential": true,
+//       "portMappings": [
+//         {
+//           "containerPort": 3000,
+//           "hostPort": 3000,
+//           "protocol": "tcp"
+//         }
+//       ]
+//     }
+//   ]
+// }