-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed invalid methods error in falcon 3 #32
Open
vuonglv1612
wants to merge
6
commits into
alysivji:master
Choose a base branch
from
vuonglv1612:fix/invalid_methods_in_falcon_3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−4
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e81e569
Fixed invalid methods error in falcon 3
e45d1bc
Apply changes to support falcon3
Javlopez 869998e
Update version.py
Javlopez 44c18da
Merge pull request #1 from Javlopez/upgrade-falcon-3
Javlopez aef2137
Merge branch 'fix/invalid_methods_in_falcon_3' into master
Javlopez 13734f0
Merge pull request #1 from Javlopez/master
vuonglv1612 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one needs to be fixed as well, because I'll not work with
falcon==3.0
, neither.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aslantar I'm using this awesome plugin, but I really would like to use it with falcon3, can I send these changes again in another PR - branch?, I've tested and seems it is working fine with falcon3, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @aslantar, I've been busy lately so I missed your review.
Thanks @Javlopez, please help me fix this problem, I don't have enough time to continue to maintain this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Javlopez, sure. I'd love to see the changes integrated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aslantar the PR is here #34 please take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Javlopez why do you need a separate PR with the same changes, instead of assisting @vuonglv1612 to get this one done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello, sorry I didn't see this before, well just I found a way to send eveything in one PR, but you are right I can send my changes to @vuonglv1612 repo, for me is ok, I gonna send them today later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aslantar I've opened a PR for in the fork vuonglv1612#1 just with the missing changes, @vuonglv1612 can you take a look please?
Best Regards