Don't throw error from flutter-l10n-flycheck workdir function #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throwing an error from the working-directory function leads to freezes in buffers that produce an error. `(flutter-project-get-root)` throws an error when the project is not a flutter project. This change fixes the freezes experienced in `dart-mode` buffers for files that are not part of a flutter project.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing an error from the working-directory function leads to freezes in buffers that produce an error.
(flutter-project-get-root)throws an error when the project is not a flutter project.This change fixes the freezes experienced in
dart-modebuffers for files that are not part of a flutter project.