Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Password strength indicator #67

Merged
merged 2 commits into from
Oct 20, 2023
Merged

ADD: Password strength indicator #67

merged 2 commits into from
Oct 20, 2023

Conversation

bj-jiwrajka
Copy link
Contributor

closes #66

@welcome
Copy link

welcome bot commented Oct 18, 2023

🛠️ Pull Request Opened 🛠️
💖Thanks for the PR| Be sure to star ⭐ the repo !💖

Please:

  1. Describe your changes.
  2. Link to the related issue.
  3. Update documentation if needed.

Our team will review it soon. Feel free to ask questions.

Thanks for contributing!

Best,
RobustKey Team
Happy Coding 💻

package.json Outdated
@@ -16,10 +16,13 @@
"axios": "^1.5.1",
"gh-pages": "^5.0.0",
"hamburger-react": "^2.5.0",
"isemail": "^3.2.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you have installed isemail package? What is use of this pakage in this project?

Copy link
Owner

@amanrajrana amanrajrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amanrajrana amanrajrana merged commit 43d2828 into amanrajrana:main Oct 20, 2023
1 check passed
@welcome
Copy link

welcome bot commented Oct 20, 2023

🎉 Congratulations! 🎉
Your pull request has been approved and is now merged into the project! 🚀 Thank you for your valuable contribution to our open-source community.

Your dedication and hard work have made our project even better. We truly appreciate your effort in helping us improve and grow.

If you have any more ideas, suggestions, or contributions in the future, please don't hesitate to reach out. We welcome your continued involvement in our project.

Once again, thank you for your commitment and for making a positive impact on our open-source journey. 🙌

Cheers,
RobustKey Team
Happy Coding 💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⭐ [Feature] Password Strength Indicator
2 participants