feat: exit as builtin function
#402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is it really necessary to remove it from std/env tho? |
|
It's not necessary if we don't want to add it in the |
|
Well at that point it will be a conflict? We should keep a duplicate? |
Ph0enixKM
reviewed
Aug 18, 2024
src/modules/builtin/exit.rs
Outdated
|
|
||
| fn parse(&mut self, meta: &mut ParserMetadata) -> SyntaxResult { | ||
| token(meta, "exit")?; | ||
| syntax(meta, &mut self.code)?; |
There was a problem hiding this comment.
Just thinking if we should allow omitting this parameter - this way we could just exit with zero exit code.
exit
// Same as `exit 0`
There was a problem hiding this comment.
It's kinda too late tbh but updated the PR to handle parsing of the code argument for the Exit statement as optional. If the code is omitted during parsing, it will now default to 0.
Mte90
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr +
#401should close #215