Fix tests not being rerun #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the |
b1ek
requested review from
FedericoCeratto,
Mte90,
CymDeveloppement,
hdwalters,
Ph0enixKM,
mks-h and
KrosFire
|
For me this change recompiles the whole test suite each time I run Honestly, I'm fine with this, so LGTM. |
mks-h
approved these changes
Sep 8, 2024
Mte90
pushed a commit
to Mte90/Amber
that referenced
this pull request
Sep 19, 2024
* fix: tests not being rerun after new test has been added * fix: add newline at end of build.rs * fix: add build-helper to deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i've got a feeling that most of you guys have faced this each time you add a new test.
turns out it has been already known, and the fix is pretty simple