Fix local installation failures #532
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile blocks first check `py-venv-check` to make sure python virtual environment is activated. If each block has multiple python commands to run,like `install-i18n` block, this approach fails. This problem gets resolved with the use of a separate script to activate venv.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main aim of the PR is to fix the build issues in local environment (the first step
make installfails). This change addresses issue - #523 @shreevatsaChanges:
uvto manage python virtual environment. README file is updated accordingly.activate.shfile to runMakefile sectionswith multiple python commands (eg.install-i18n).requirements.txtfile