Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with missing feature flag. #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicolas-sabbatini
Copy link

@nicolas-sabbatini nicolas-sabbatini commented Nov 2, 2021

The readme file is missing the codegen feature flag.

Description

I just added the missing feature flag.

Motivation and Context

If you read the readme and tray to use the lib in a wasm project, the build is going to fail, and you are not going to know why.

How Has This Been Tested?

It displays correctly in the GitHub README.

Checklist:

  • Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme.
  • My code follows the code style of this project.
  • If my change required a change to the documentation I have updated the documentation accordingly.
  • I have updated the content of the book if this PR would make the book outdated.
  • I have added tests to cover my changes.
  • My code is used in an example.

The readme file is missing the codegen feature flag.
@nicolas-sabbatini
Copy link
Author

I believe that the last 4 point of the checklist don't apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant