-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #773 #774
Fix #773 #774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for this improvement, it looks great!
I left one suggestion for improving the docs.
I added an explanation, that #[storage(...)] accepts storage types with type parameters. |
Apparently I required one more I apologise for the trouble and thank you for your patience with me. |
I dont know how to fix the failing check on nightly, nor am I sure, it is caused by this pull request. |
No worries, it isn't caused by this PR. I'm planning to do some quick testing to confirm works with the new derive logic, and will merge this after I do that. |
Hi,
This fixes #773 .
Checklist
I thought this was already possible based on the resources mentioned in the list above.
Therefore, I have not changed anything and don't think anything needs to be added / changed.
-ClaasJG