Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainers and CODEOWNERS files #282

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Nov 8, 2024

Update the CODEOWNERS file and maintainers information in both pyproject.toml and README to reflect current contributors.


📚 Documentation preview 📚: https://jaxsim--282.org.readthedocs.build//282/

@flferretti flferretti self-assigned this Nov 8, 2024
@flferretti flferretti marked this pull request as ready for review November 8, 2024 15:33
@flferretti flferretti force-pushed the chores/maintainers_update branch from a58c311 to aff8212 Compare November 8, 2024 16:04
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flferretti! I just want to let all of you know that, despite I will no longer be among the codeowners since I'm leaving IIT, I still plan to use -and possibly, contribute- to the project. I'll keep an eye to the PRs, expect some occasional review / random comment. On your end, feel free to tag me in any issue / PR, but feel free to proceed even without my feedback.

@diegoferigo
Copy link
Member

diegoferigo commented Nov 13, 2024

On ownership/contributors/maintainers, the same commented in ami-iit/rod#47 (comment) also applies here. Considering the past contributions of @flferretti and what I expect in the future, I can consider @flferretti as second author. Feel free to adjust the project accordingly.

@flferretti flferretti force-pushed the chores/maintainers_update branch from aff8212 to 7077284 Compare November 13, 2024 14:28
@flferretti flferretti force-pushed the chores/maintainers_update branch from 7077284 to cd7f634 Compare November 13, 2024 14:31
README.md Outdated Show resolved Hide resolved
@flferretti flferretti force-pushed the chores/maintainers_update branch from cd7f634 to bf72dbc Compare November 13, 2024 14:33
@flferretti
Copy link
Collaborator Author

The RTD CI fails doesn't seems related to this PR, as it happens also in #274.

RTD Log

 Running Sphinx v8.1.3
loading translations [en]... done
Matplotlib is building the font cache; this may take a moment.
Using Sphinx-Gallery to convert rst text blocks to markdown for .ipynb files.
Read in collections ...
  examples: Initialised
Clean collections ...
  examples: (CopyFolderDriver) Folder deleted: /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/_collections/examples
Executing collections ...
  examples: (CopyFolderDriver) Copy folder...
Converting `source_suffix = ['.rst', '.md', '.ipynb']` to `source_suffix = {'.rst': 'restructuredtext', '.md': 'restructuredtext', '.ipynb': 'restructuredtext'}`.
[autosummary] generating autosummary for: _collections/examples/README.md, _collections/examples/jaxsim_as_multibody_dynamics_library.ipynb, _collections/examples/jaxsim_as_physics_engine.ipynb, _collections/examples/jaxsim_for_robot_controllers.ipynb, examples.rst, guide/install.rst, index.rst, modules/api.rst, modules/integrators.rst, modules/math.rst, modules/mujoco.rst, modules/parsers.rst, modules/rbda.rst, modules/typing.rst, modules/utils.rst
[autosummary] generating autosummary for: /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.com.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.common.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.contact.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.data.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.frame.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.joint.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.kin_dyn_parameters.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.link.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.model.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.ode.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.ode_data.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.api.references.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.rbda.aba.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.rbda.collidable_points.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.rbda.contacts.soft.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.rbda.crba.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.rbda.forward_kinematics.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.rbda.jacobian.rst, /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/modules/_autosummary/jaxsim.rbda.utils.rst
myst v4.0.0: MdParserConfig(commonmark_only=False, gfm_only=False, enable_extensions={'amsmath', 'dollarmath'}, disable_syntax=[], all_links_external=False, links_external_new_tab=False, url_schemes=('http', 'https', 'mailto', 'ftp'), ref_domains=None, fence_as_directive=set(), number_code_blocks=[], title_to_header=False, heading_anchors=0, heading_slug_func=None, html_meta={}, footnote_sort=True, footnote_transition=True, words_per_minute=200, substitutions={}, linkify_fuzzy_links=True, dmath_allow_labels=True, dmath_allow_space=True, dmath_allow_digits=True, dmath_double_inline=False, update_mathjax=True, mathjax_classes='tex2jax_process|mathjax_process|math|output_area', enable_checkboxes=False, suppress_warnings=[], highlight_code_blocks=True)
myst-nb v1.1.2: NbParserConfig(custom_formats={}, metadata_key='mystnb', cell_metadata_key='mystnb', kernel_rgx_aliases={}, eval_name_regex='^[a-zA-Z_][a-zA-Z0-9_]*$', execution_mode='auto', execution_cache_path='', execution_excludepatterns=(), execution_timeout=180, execution_in_temp=False, execution_allow_errors=False, execution_raise_on_error=True, execution_show_tb=False, merge_streams=False, render_plugin='default', remove_code_source=False, remove_code_outputs=False, code_prompt_show='Show code cell {type}', code_prompt_hide='Hide code cell {type}', number_source_lines=False, output_stderr='show', render_text_lexer='myst-ansi', render_error_lexer='ipythontb', render_image_options={'scale': '60'}, render_figure_options={}, render_markdown_format='commonmark', output_folder='build', append_css=True, metadata_to_fm=False)
Using jupyter-cache at: /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/_readthedocs/.jupyter_cache
generating gallery...
generating gallery for ../generated_examples... 
computation time summary:
building [mo]: targets for 0 po files that are out of date
writing output... 
building [html]: targets for 15 source files that are out of date
updating environment: [new config] 35 added, 0 changed, 0 removed
reading sources... [  3%] _collections/examples/README
reading sources... [  6%] _collections/examples/jaxsim_as_multibody_dynamics_library
/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/_collections/examples/jaxsim_as_multibody_dynamics_library.ipynb: Executing notebook using local CWD [mystnb]
/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/_collections/examples/jaxsim_as_multibody_dynamics_library.ipynb: Executed notebook in 50.53 seconds [mystnb]
reading sources... [  9%] _collections/examples/jaxsim_as_physics_engine
/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/_collections/examples/jaxsim_as_physics_engine.ipynb: Executing notebook using local CWD [mystnb]
/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/_collections/examples/jaxsim_as_physics_engine.ipynb: Executed notebook in 53.48 seconds [mystnb]
reading sources... [ 11%] _collections/examples/jaxsim_for_robot_controllers
/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/_collections/examples/jaxsim_for_robot_controllers.ipynb: Executing notebook using local CWD [mystnb]

====================== slowest reading durations =======================
53.519 _collections/examples/jaxsim_as_physics_engine
50.593 _collections/examples/jaxsim_as_multibody_dynamics_library
0.010 _collections/examples/README
Final clean of collections ...
  examples: (CopyFolderDriver) Folder deleted: /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/_collections/examples

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/jupyter_cache/executors/utils.py", line 58, in single_nb_execution
    executenb(
    ~~~~~~~~~^
        nb,
        ^^^
    ...<4 lines>...
        **kwargs,
        ^^^^^^^^^
    )
    ^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/nbclient/client.py", line 1314, in execute
    return NotebookClient(nb=nb, resources=resources, km=km, **kwargs).execute()
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/jupyter_core/utils/__init__.py", line 165, in wrapped
    return loop.run_until_complete(inner)
           ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/asyncio/base_events.py", line 721, in run_until_complete
    return future.result()
           ~~~~~~~~~~~~~^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/nbclient/client.py", line 709, in async_execute
    await self.async_execute_cell(
        cell, index, execution_count=self.code_cells_executed + 1
    )
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/nbclient/client.py", line 1062, in async_execute_cell
    await self._check_raise_for_error(cell, cell_index, exec_reply)
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/nbclient/client.py", line 918, in _check_raise_for_error
    raise CellExecutionError.from_cell_and_msg(cell, exec_reply_content)
nbclient.exceptions.CellExecutionError: An error occurred while executing the following cell:
------------------
# @title Create the model and its data

import jaxsim.api as js

# Create the model from the model description.
model = js.model.JaxSimModel.build_from_model_description(
    model_description=model_urdf_string,
    time_step=0.010,
)

# Create the data storing the simulation state.
data_zero = js.data.JaxSimModelData.zero(model=model)
------------------


�[0;31m---------------------------------------------------------------------------�[0m
�[0;31mNameError�[0m                                 Traceback (most recent call last)
Cell �[0;32mIn[3], line 7�[0m
�[1;32m      3�[0m �[38;5;28;01mimport�[39;00m �[38;5;21;01mjaxsim�[39;00m�[38;5;21;01m.�[39;00m�[38;5;21;01mapi�[39;00m �[38;5;28;01mas�[39;00m �[38;5;21;01mjs�[39;00m
�[1;32m      5�[0m �[38;5;66;03m# Create the model from the model description.�[39;00m
�[1;32m      6�[0m model �[38;5;241m=�[39m js�[38;5;241m.�[39mmodel�[38;5;241m.�[39mJaxSimModel�[38;5;241m.�[39mbuild_from_model_description(
�[0;32m----> 7�[0m     model_description�[38;5;241m=�[39m�[43mmodel_urdf_string�[49m,
�[1;32m      8�[0m     time_step�[38;5;241m=�[39m�[38;5;241m0.010�[39m,
�[1;32m      9�[0m )
�[1;32m     11�[0m �[38;5;66;03m# Create the data storing the simulation state.�[39;00m
�[1;32m     12�[0m data_zero �[38;5;241m=�[39m js�[38;5;241m.�[39mdata�[38;5;241m.�[39mJaxSimModelData�[38;5;241m.�[39mzero(model�[38;5;241m=�[39mmodel)

�[0;31mNameError�[0m: name 'model_urdf_string' is not defined


The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/sphinx/cmd/build.py", line 514, in build_main
    app.build(args.force_all, args.filenames)
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/sphinx/application.py", line 381, in build
    self.builder.build_update()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/sphinx/builders/__init__.py", line 358, in build_update
    self.build(
    ~~~~~~~~~~^
        to_build,
        ^^^^^^^^^
        summary=__('targets for %d source files that are out of date')
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        % len(to_build),
        ^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/sphinx/builders/__init__.py", line 385, in build
    updated_docnames = set(self.read())
                           ~~~~~~~~~^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/sphinx/builders/__init__.py", line 502, in read
    self._read_serial(docnames)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/sphinx/builders/__init__.py", line 567, in _read_serial
    self.read_doc(docname)
    ~~~~~~~~~~~~~^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/sphinx/builders/__init__.py", line 630, in read_doc
    publisher.publish()
    ~~~~~~~~~~~~~~~~~^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/docutils/core.py", line 234, in publish
    self.document = self.reader.read(self.source, self.parser,
                    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     self.settings)
                                     ^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/sphinx/io.py", line 106, in read
    self.parse()
    ~~~~~~~~~~^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/docutils/readers/__init__.py", line 76, in parse
    self.parser.parse(self.input, document)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/myst_nb/sphinx_.py", line 152, in parse
    with create_client(
         ~~~~~~~~~~~~~^
        notebook, document_path, nb_config, logger, nb_reader.read_fmt
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ) as nb_client:
    ^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/myst_nb/core/execute/base.py", line 79, in __enter__
    self.start_client()
    ~~~~~~~~~~~~~~~~~^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/myst_nb/core/execute/direct.py", line 50, in start_client
    raise ExecutionError(str(self.path)) from result.err
myst_nb.core.execute.base.ExecutionError: /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/_collections/examples/jaxsim_for_robot_controllers.ipynb

Exception occurred:
  File "/home/docs/checkouts/readthedocs.org/user_builds/jaxsim/conda/282/lib/python3.13/site-packages/myst_nb/core/execute/direct.py", line 50, in start_client
    raise ExecutionError(str(self.path)) from result.err
myst_nb.core.execute.base.ExecutionError: /home/docs/checkouts/readthedocs.org/user_builds/jaxsim/checkouts/282/docs/_collections/examples/jaxsim_for_robot_controllers.ipynb
The full traceback has been saved in /tmp/sphinx-err-hy_dofzu.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks! 

@flferretti
Copy link
Collaborator Author

flferretti commented Nov 13, 2024

From this

" logging.error(\"Failed to fetch data\")"
it'd be better if we just raise an error:

if response.status_code == 200:
    model_urdf_string = response.text
else:
    raise RuntimeError("Failed to fetch data.")

I'll open a PR for that. In the meanwhile, I believe we can merge this

Edit: This passes locally, so it's related to RTD runner

@flferretti flferretti merged commit 2f942bf into main Nov 13, 2024
23 of 24 checks passed
@flferretti flferretti deleted the chores/maintainers_update branch November 13, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants