fixed dates/calendar data [from 1975 to 2100]

[manish404]

Hello,
I've updated dates in calendar.csv, as i found they're important in date validation.
Dates are scraped from nepalipatro.
The javascript file to scrape data is also uploaded there for further use.

[amitgaru2]

@manish404 I am following nepcal, I did check nepalipatro and seems like there is contradiction in number of days in months for different years as you have pointed. Can you please check other sources as well to validate which one is actually correct? Let me know the links you checked other than nepalipatro, I will verify and move forward with the correct one.

[manish404]

calendar-nepcal.txt

I found differences in every year from 2082 to 2100 in both nepali patro and nepcal, and some differences in hamropatro too.
Do they pick randomly?

[amitgaru2]

@manish404 can you be more specific on the differences you spotted on the sites other than nepcal and nepalipatro?

[manish404]

I think people mostly use hamropatro or nepalipatro, so in my project i used nepali-patro's data, i can't say mine is correct as i found different sites have different future data. I needed future dates verification too, so i have to go with nepali patro's data.
Your approach is good cause there're no issues till now. Nice package, nice work, Thank you.

if possible, can you keep this data somewhere with guidance, so if someone needs it, they can tweak and use the data of nepali patro.

[dibashbitskraft]

Hello @amitgaru2 , I also found difference in year 2082 and forked to resolve, And i think this PR should be merged as we also use HamroPatro for reference.

[amitgaru2]

@manish404 @dibashbitskraft ok I think we should follow hamropatro for reference as it is the most popular one. @manish404 can you check your PR again and align the dates with hamropatro only?

[amitgaru2]

@manish404 please remove scraper.js from your PR as it is not needed in the source code.

[manish404]

I think hamro patro recently updated it, before it was 2082,31,31,31,32,31,31,30,29,30,29,30,30.

calendar_hamropatro.txt
calendar_nepalipatro.txt
calendar-nepcal.txt

[amitgaru2]

@manish404 then seems like there is no trustable source for future dates.

[manish404]

2062 - baisakh is wrong, why? In all those 3 calendars it's 31, but in the data it's 30.

[amitgaru2]

@manish404 yeah for 2062 B.S, Baishak should have 31 days and Jestha should have 31 days. Can you create a new PR fixing these dates?

[manish404]

we can merge now!

[amitgaru2]

@manish404 I meant create a new PR not update this one. I have just found discrepancy for 2062 B.S. not others. We are still using nepcal.com as our source of date.

[manish404]

ohh, update in nepcal and package too.

2062,31,31,31,32,31,31,29,30,29,30,29,31

[amitgaru2]

@manish404 I am telling you to do that so that your name gets listed in contributors list as you found it.