-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ios crash #84
Fix ios crash #84
Conversation
998d0c1
to
3bb4dad
Compare
Thanks @extrawurst. Can you please also share what kind of URL was breaking this? |
This is good to go, but I'll wait to hear about the URL that caused this issue, so that I can modify the tests for it accordingly. The patch release will happen after that. |
I tried |
you can test this with the |
There are tests that run every time on the sim for iOS (you can check yourself by having a sim on, and running let _ = webbrowser::open("https://bevyengine.org"); and it ran just fine in the sim (opened that url). Initially I'd thought it's some url with weird characters. Have you verified that this change fixes the issue on your machine? |
yes on sim and device |
Cool. This is now released as v0.8.15. Thanks for your contribution. |
@amodm thanks! I tried to run your tests but could not, but I am intrigued as I am working on objc2 ios bindings more often: https://github.com/rustunit/bevy_ios_impact on running
|
@extrawurst, seems to be an issue with the provisioning profile. You may need to open Here's a rundown of the test architecture:
If debugging feels too much work, and you suspect |
fixes #83