Issues/0146 strict aliasing violations #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
michaeldsmith
commented
Apr 2, 2024
michaeldsmith
commented
- adds docker with link-time-optimization (LTO) enabled and strict aliasing warnings as errors
- addresses Build fails with strict-aliasing violations #146 strict aliasing issue with explicit memcpy() workaround, as described by C.183 recommend bit_cast for type punning isocpp/CppCoreGuidelines#1987
- removes optional tiff from vcpkg.json and github vcpkg workflows. Libtiff on vcpkg depends on liblzma. Liblzma has security issue [liblzma] port uses compromised version microsoft/vcpkg#37839. Hopefully this issue will be addressed in the future, which would allow vcpkg to be used with CTL and option libtiff again.
michaeldsmith
added a commit
that referenced
this pull request
Apr 22, 2024
* restores tiff to vcpkg github workflow that was removed in #147 due to a security issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.