Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update step-002.md #429

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update step-002.md #429

wants to merge 2 commits into from

Conversation

Sixchalice
Copy link

explained an error that may appear for macos users and how to avoid it.

explained an error that may appear for macos users and how to avoid it.
@dericksozo dericksozo self-requested a review December 25, 2023 05:46
@dericksozo dericksozo added the documentation Improvements or additions to documentation label Dec 25, 2023
@dericksozo
Copy link
Contributor

Hey @Sixchalice, thanks for your PR. It's possible that you might have encountered an error with the AirPlay Receiver, which made you update the tutorial. The information you provided is valuable. However, the details about the AirPlay Receiver might be too specific. It would be great if we could wrap this in a :::note ::: and make it more general for users who wish to change ports.

CC @PazYanoverr. What are your thoughts?

@PazYanoverr
Copy link
Member

Thanks @Sixchalice!
@dericksozo - Fully agree with your comment. Like you said- we should probably wrap this change in a "note", and write something more general in it. For example- how one can check whether the port is taken (by any software), and which line should be changed to pick a different port

made the solution more general for all users to know how to switch the frontend port
@Sixchalice
Copy link
Author

Not sure if this is what you meant by "Note" but i think this is clear enough. thanks

@PazYanoverr
Copy link
Member

@dericksozo - Can you please review?

@dericksozo
Copy link
Contributor

Hey @Sixchalice, Happy New Years. How's it going with this one? Please let me know if I can answer any more questions.

@Sixchalice
Copy link
Author

Sixchalice commented Jan 3, 2024

Hey, I made it more generalized for all users, was there another task/change you wanted me to do? thanks

@dericksozo
Copy link
Contributor

dericksozo commented Jan 4, 2024

Definitely, @Sixchalice. The text is great, but the formatting can be more Docusaurus-specific. Can you please replace line 205 to 208 with the following:

:::note
If you encounter an error indicating that port 5000 is already in use, it means another software may be using the port, causing a conflict. This issue can be resolved by changing the port used for the frontend in package.json. Update the start script for the frontend to use a different port, for instance:

"start:frontend": "cross-env PORT=5001 npm --prefix web start",

:::

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants