Docs: Authentication Entity Updates For .NET #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age to account for the differences between .NET and Node.js authentication implementations.
PazYanoverr
reviewed
Jun 27, 2024
| @@ -20,7 +20,7 @@ However, you can choose to use your own custom Authentication entity as long as | |||
|
|
|||
| ## Dependencies Between the Authentication Entity and Authentication Plugins | |||
|
|
|||
| The authentication plugins, such as the _NestJS Auth Module_ and others, rely on the existence of an _Authentication_ entity to handle user authentication and authorization. | |||
| The authentication plugins rely on the existence of an _Authentication_ entity to handle user authentication and authorization. For Node.js services, this includes the _NestJS Auth Module_ and others. For .NET services, this includes the _ASP.NET Core Identity_ plugin. | |||
There was a problem hiding this comment.
I think it should be "For Node.js services, this includes the NestJS Auth Module or others".
I.e. "or" instead of "and". Is that correct- English-wise?
| @@ -32,15 +32,15 @@ An Authentication plugin requires an Authentication entity containing the proper | |||
|
|
|||
| By default, the 'User' entity is defined as the Authentication entity, but you can [configure it](#changing-the-default-authentication-entity). If the `User` entity is created automatically, it comes with a set of default fields necessary for the authentication plugins to work correctly: | |||
|
|
|||
| - `id` (required by all authentication plugins): An automatically created unique identifier of the entity. It is a required and unique field. | |||
There was a problem hiding this comment.
@mulygottlieb - Can you please review the list and whether the "required" fields are indeed required for all the auth plugins (.NET and Node.js)?
|
@mulygottlieb - As discussed, and since the .NET auth behavior is different from the Node.js one- please share a doc with us that describes the auth behavior on .NET. Thanks! |
|
Thanks, @PazYanoverr @mulygottlieb. I'll keep posted for any additional materials. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(docs): Making changes to the
Authentication Entitydocumentation page to account for the differences between .NET and Node.js authentication implementations.This PR takes care of #489.