Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI:add new builds #449

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

CI:add new builds #449

wants to merge 4 commits into from

Conversation

ccraluca
Copy link
Contributor

Add bullseye and rpi4 builds on Azure CI.

Signed-off-by: Raluca Groza <raluca.groza@analog.com>
Signed-off-by: Raluca Groza <raluca.groza@analog.com>
@@ -117,6 +117,10 @@ stages:
image: tfcollins/libiio_ubuntu_18_04-ci-arm-ppc:latest
arch: aarch64
artifactName: 'Ubuntu-arm64v8'
bullseye:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change name to have the same format: "debian_bullseye_arm64v8"?
And I think you can add a build for 32bit image just by specifying "arch: arm"

source: 'specific'
project: '$(System.TeamProjectId)'
pipeline: $(libiioPipelineId)
artifact: 'Ubuntu-arm32v7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using artifacts from Ubuntu inside RPI build (line #114, #124, #134 etc)?
Even if that would work, it is not ok.

@@ -94,6 +94,63 @@ stages:

#######################################

- job: RPIBuilds
pool:
name: Default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to let the agent connected to "Default" pool?

I'm mean, if there are other jobs that are using "Default Pool" for building things, but without specifying an explicit agent, the build may go on this.

- script: |
mkdir build && cd build
cmake ../
make -j9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RPI do not have 9 CPU cores. This kind of builds will just kill it (freeze it) for at least few minutes.
Please check how many cores its CPU has and set make command to use maximum threads.

- task: PublishPipelineArtifact@1
inputs:
targetPath: '$(Build.ArtifactStagingDirectory)'
artifactName: 'RPI4-Bullseye'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add also architecture in the name of artifacts(armhf).

@ccraluca ccraluca marked this pull request as draft August 23, 2023 08:23
Signed-off-by: Raluca Groza <raluca.groza@analog.com>
Signed-off-by: Raluca Groza <raluca.groza@analog.com>
@SRaus SRaus changed the base branch from master to main January 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants