Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Build): Fix Cordio Build Error for BT_VER = 11 #1013

Merged
merged 1 commit into from
May 11, 2024
Merged

fix(Build): Fix Cordio Build Error for BT_VER = 11 #1013

merged 1 commit into from
May 11, 2024

Conversation

Jake-Carter
Copy link
Contributor

@Jake-Carter Jake-Carter commented May 11, 2024

Description

BT_VER was not being explicitly passed down to the sub-make call that built the Cordio library. This should fix the following linker errors when attempting to build with BT_VER = 11 set in project.mk:

- LD /home/jhcarter/repos/msdk/Examples/MAX32655/Bluetooth/BLE5_ctr/build/max32655.elf
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Examples/MAX32655/Bluetooth/BLE5_ctr/build/init_ctr.o: in function `LlInitLhciHandler':
/home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init_ctr.c:42: undefined reference to `LhciIsoHandlerInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init_ctr.c:47: undefined reference to `LhciIsoHandler'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Examples/MAX32655/Bluetooth/BLE5_ctr/build/init_ctr.o: in function `LlInitLhciInit':
/home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init_ctr.c:127: undefined reference to `LhciCisMasterInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init_ctr.c:128: undefined reference to `LhciBisMasterInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init_ctr.c:136: undefined reference to `LhciBisSlaveInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init_ctr.c:140: undefined reference to `LhciCisSlaveInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init_ctr.c:143: undefined reference to `LhciIsoInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Examples/MAX32655/Bluetooth/BLE5_ctr/build/init.o: in function `LlInitBbInit':
/home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init.c:79: undefined reference to `BbBleCisMasterInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init.c:82: undefined reference to `BbBleCisSlaveInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init.c:88: undefined reference to `BbBleBisSlaveInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Examples/MAX32655/Bluetooth/BLE5_ctr/build/init.o: in function `LlInitLlInit':
/home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init.c:155: undefined reference to `LlCisMasterInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init.c:156: undefined reference to `LlBisMasterInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init.c:172: undefined reference to `LlCisSlaveInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init.c:173: undefined reference to `LlBisSlaveInit'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Examples/MAX32655/Bluetooth/BLE5_ctr/build/init.o: in function `LlInitSetLlRtCfg':
/home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init.c:285: undefined reference to `LlInitCisMem'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init.c:290: undefined reference to `LlInitBisMem'
/home/jhcarter/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/jhcarter/repos/msdk/Libraries/Cordio/controller/sources/ble/init/init.c:295: undefined reference to `LlInitIsoMem'
collect2: error: ld returned 1 exit status
make: *** [/home/jhcarter/repos/msdk/Libraries/CMSIS/Device/Maxim/GCC/gcc.mk:568: /home/jhcarter/repos/msdk/Examples/MAX32655/Bluetooth/BLE5_ctr/build/max32655.elf] Error 1

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@Jake-Carter Jake-Carter requested a review from yc-adi May 11, 2024 00:47
@github-actions github-actions bot added the BLE Related to Bluetooth label May 11, 2024
@Jake-Carter Jake-Carter changed the title fix(Cordio): Fix Cordio Build Error for BT_VER = 11 fix(Build): Fix Cordio Build Error for BT_VER = 11 May 11, 2024
@yc-adi yc-adi merged commit d01ad7b into main May 11, 2024
8 of 12 checks passed
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
@Jake-Carter Jake-Carter deleted the fix/bt_ver branch October 23, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLE Related to Bluetooth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants