feat(MiscDrivers): Add APS6404 SRAM Drivers #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use fastspi from Libraries/MiscDrivers - Update fastspi to accept SS number as an argument - Add fastspi to MAX78002EVKIT BSP
github-actions
bot
added
MAX78000
sihyung-maxim
approved these changes
Aug 26, 2024
Comment on lines
+32
to
+41
| // Utility macro for validating an error code. Assumes an 'err' variable | ||
| // of type int exists in the macro's context | ||
| #define ERR_CHECK(x) \ | ||
| { \ | ||
| err = (x); \ | ||
| if (err != E_NO_ERROR) { \ | ||
| return x; \ | ||
| } \ | ||
| } | ||
|
|
There was a problem hiding this comment.
This definition is really nice. Moving forward, maybe we can start using this to minimize all the error-if statements that are widespread across our drivers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds APS6404 SRAM support to our MiscDrivers. The MAX78002EVKIT has an on-board APS6404 which is primarily used to buffer image data.
Previously these were local to the QSPI example project. This PR updates them to use the common fastspi implementation, configured via a "fastspi_config.h" file in the MAX78002EVKIT BSP.
It also cleans up the implementation, API, and example code.
Checklist Before Requesting Review
Tests
QSPI example validation: