perf(Boards, MiscDrivers): Reduce refresh time and add font color selection on TFT Display drivers for MAX32690 #1107
Conversation
… added text fill color selection in display library
|
/clang-format-run |
| @@ -214,15 +213,10 @@ void TFT_SPI_Write(uint8_t *datain, uint32_t count, bool data) | |||
| tx_byte = tx_byte << 1; | |||
| } | |||
|
|
|||
| for (int k = 0; k < 2; k++) {} | |||
There was a problem hiding this comment.
Since we're bit-banging these drivers the delays are to ensure we're compliant with the timing requirements of the ST7735.
By removing them we're now completely reliant on the overhead associated with the memory operations to ensure we're not violating the timings. This will vary based on the frequency of the master clock.
Running off the highest frequency IPO (120Mhz) it's possible to violate the minimum TSYCW and TSYCR by a narrow margin.
I agree with removing the 10uS CS settling delays, but I think these for loops should be kept. What is the refresh rate with them back in?
There was a problem hiding this comment.
I would be shocked if that for loop was not being optimized away.
| @@ -216,12 +216,25 @@ void MXC_TFT_ResetCursor(void); | |||
| * | |||
| * @param x0 x location on screen | |||
| * @param y0 y location on screen | |||
| * @param fon_id Font number | |||
| * @param id Font number ID | |||
There was a problem hiding this comment.
Should be @param font_id, or rename the variable in the function declaration to id.
|
Closing this as we no longer have access to the fork. Same changes in #1110 |
Description
Slight modifications to the TFT LCD display drivers on the MAX32690 EV Kit V1 board.
TFT_SPI_Write()to reduce the screen refresh time from 0.87129 seconds to 0.120858 seconds -- an 86% improvement.MXC_TFT_PrintFont()would use the initially set background color around the printed text. Added a function to offer color selection of both the background and the font text.Checklist Before Requesting Review