-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MiscDrivers): Add Ability to Set Pushbutton Polarity #1166
Conversation
The not enough memory build error for the ME18 Bootloader example has returned, but this time, it's on the ME18APARD board. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
I corrected the Bootloader example's memory configurations to their actual length - which should be enough room to prevent oversize build errors in the future. For future reference, thee ME18 Bootloader example previously assumed the two flash instances had the same flash page sizes and lengths which is incorrect. Flash 0: 3MB total, 16KB per page I'm not sure why Eddie decided the Bootloader program size is two pages long... But expanding the bootloader program shouldn't be an issue as there's more than enough memory in the ME18 to accommodate for larger programs. |
Pull Request Template
Description
Closes #1156
PB_Set_Polarity
API so that we can adapt the PB drivers to boards with different configurations.PB_POLARITY_LOW
to preserve backwards compatibility with existing boards.PB_POLARITY_HIGH
Checklist Before Requesting Review