Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MiscDrivers): Add Ability to Set Pushbutton Polarity #1166

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

Jake-Carter
Copy link
Contributor

Pull Request Template

Description

Closes #1156

  • Adds the PB_Set_Polarity API so that we can adapt the PB drivers to boards with different configurations.
  • Initialize the default polarity to PB_POLARITY_LOW to preserve backwards compatibility with existing boards.
  • Update MAX32690 APARD BSP to set PB_POLARITY_HIGH

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added the MAX32690 Related to the MAX32690 (ME18) label Sep 11, 2024
@sihyung-maxim
Copy link
Contributor

The not enough memory build error for the ME18 Bootloader example has returned, but this time, it's on the ME18APARD board.

Copy link
Contributor

@perkinsmg perkinsmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sihyung-maxim
Copy link
Contributor

sihyung-maxim commented Sep 24, 2024

I corrected the Bootloader example's memory configurations to their actual length - which should be enough room to prevent oversize build errors in the future.

For future reference, thee ME18 Bootloader example previously assumed the two flash instances had the same flash page sizes and lengths which is incorrect.

Flash 0: 3MB total, 16KB per page
Flash 1: 256KB total, 8KB per page

I'm not sure why Eddie decided the Bootloader program size is two pages long... But expanding the bootloader program shouldn't be an issue as there's more than enough memory in the ME18 to accommodate for larger programs.

@sihyung-maxim sihyung-maxim merged commit 159d804 into main Sep 25, 2024
10 checks passed
@sihyung-maxim sihyung-maxim deleted the feat/pb-polarity branch September 25, 2024 15:18
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32690 Related to the MAX32690 (ME18)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

./Libraries/MiscDrivers/PushButton/pb.c PB_Get function doesn't work on AD-APARD32690-SL board
3 participants