-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PeriphDrivers): Fix UART clock source issues #1168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh boy, another one lol. Changes looks good, double-check me @Jake-Carter
Need to be rebased first. |
72642dd
to
40663aa
Compare
Rebased. |
7ab6d17
to
f090907
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why the MXC_UART_SetClockSource
function for certain parts writes to a clock_option
variable within the switch statement, then calls the MXC_UART_RevB_SetClockSource
function at the end while other parts follow this setup?
When I review |
- Moved clock source enablement from init function to clock source selection function. - Updated clock source selection functions. - Updated clock source enums for MAX32672 and MAX32675. - Removed unused clock sources from MXC_UART_SetFrequency function. Signed-off-by: Furkan Akkiz <hasanfurkan.akkiz@analog.com>
- Added 'MXC_UART_GetClockSource' functions for me15 and me21. - Called this function to get clock source in init function for ai85. Signed-off-by: Furkan Akkiz <hasanfurkan.akkiz@analog.com>
Disabled gpio and clock enablement on UART drivers for Zephyr. Signed-off-by: Furkan Akkiz <hasanfurkan.akkiz@analog.com>
f090907
to
44e2a78
Compare
Thanks @hfakkiz, my mistake. I didn't consider |
Description
With new UART RevB clock source selection updates, some problems occurred on Zephyr RTOS side. Also, I noticed some problems about MSDK side too. In this PR,
Checklist Before Requesting Review