Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Examples): Add 2048 Demo to MAX32655 #1178

Merged
merged 28 commits into from
Sep 18, 2024
Merged

feat(Examples): Add 2048 Demo to MAX32655 #1178

merged 28 commits into from
Sep 18, 2024

Conversation

sihyung-maxim
Copy link
Contributor

Description

This PR adds the 2048 Demo which splits the task of the game between the ARM and RISC-V cores for the MAX32655.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added the MAX32655 Related to the MAX32655 (ME17) label Sep 16, 2024
…ns outside of RISCV to hide intellisense not finding definition error (build/buildrv/project_defines.h)
@sihyung-maxim
Copy link
Contributor Author

/clang-format-run

@sihyung-maxim
Copy link
Contributor Author

/clang-format-run

@sihyung-maxim
Copy link
Contributor Author

/clang-format-run

@github-actions github-actions bot added the Workflow Related to Workflow development label Sep 17, 2024
@sihyung-maxim
Copy link
Contributor Author

/clang-format-run

@sihyung-maxim
Copy link
Contributor Author

Fixed linter errors and outdated/unfinished comments. Moved all the semaphore/mailbox definitions, for both the RISCV and ARM core, into their separate ipc_defines.h which should match.

Copy link

@mharringADI mharringADI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks @sihyung-maxim! A few really minor comments but functionally works as expected.

Examples/MAX32655/Demo_2048/RISCV/inc/ipc_defines.h Outdated Show resolved Hide resolved
Examples/MAX32655/Demo_2048/RISCV/inc/ipc_defines.h Outdated Show resolved Hide resolved
Examples/MAX32655/Demo_2048/RISCV/inc/ipc_defines.h Outdated Show resolved Hide resolved
Examples/MAX32655/Demo_2048/ARM/inc/ipc_defines.h Outdated Show resolved Hide resolved
Examples/MAX32655/Demo_2048/ARM/inc/ipc_defines.h Outdated Show resolved Hide resolved
Examples/MAX32655/Demo_2048/ARM/inc/ipc_defines.h Outdated Show resolved Hide resolved
Libraries/MiscDrivers/Display/tft_ssd2119.c Outdated Show resolved Hide resolved
@sihyung-maxim sihyung-maxim merged commit 53fc098 into main Sep 18, 2024
9 checks passed
@sihyung-maxim sihyung-maxim deleted the feat/demo_2048 branch September 18, 2024 15:27
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32655 Related to the MAX32655 (ME17) Workflow Related to Workflow development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants