chore(PeriphDrivers): Replace pow() with left shift in MAX32670 and MAX32672 UART drivers #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pow(2, aon_clk_div) can be replaced with (1 << aon_clk_div) to eliminate the need to include <math.h>. Signed-off-by: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
github-actions
bot
added
MAX32670
|
Is this change reasonable for you, @Jake-Carter, @sihyung-maxim? Thanks. |
ttmut
changed the title
ozersa
approved these changes
Oct 8, 2024
MaureenHelm
approved these changes
Oct 8, 2024
sihyung-maxim
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
aon_clk_divis an integer,pow(2, aon_clk_div)can be replaced with(1 << aon_clk_div)inMXC_UART_SetFrequency. This eliminates the need to include <math.h> in UART driver.Motive
Zephyr uses its own math library which provides an implementation of
pow(). When running batch tests, however, it switches to a minimal implementation of the C library that does not include thepow()function. As a result, UART drivers cannot be compiled and tests fail.Checklist Before Requesting Review