Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CMSIS): Remove unused includes for MAX32672 #1220

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ttmut
Copy link
Contributor

@ttmut ttmut commented Oct 9, 2024

Description

Remove inclusion of trimsir_regs.h and aes_regs.h from max32672.h. They are causing redefinition warnings for #define __I volatile const macro in some cases.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

Remove inclusion of trimsir_regs.h and aes_regs.h from max32672.h.

Signed-off-by: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
@github-actions github-actions bot added the MAX32672 Related to the MAX32672 (ME21) label Oct 9, 2024
Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, it's been awhile lol. Thanks for catching this.

@sihyung-maxim sihyung-maxim merged commit 8ece572 into main Oct 9, 2024
13 checks passed
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Oct 9, 2024
@sihyung-maxim sihyung-maxim deleted the chore/me21_cleanup branch October 9, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32672 Related to the MAX32672 (ME21)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants