fix(MiscDrivers): Fix Blank MAX78000EVKIT TFT Display #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihyung-maxim
approved these changes
Apr 5, 2024
EricB-ADI
pushed a commit
that referenced
this pull request
Aug 21, 2024
This reverts commit aad12c7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
After #880, @aniktash reported the TFT on the MAX78000EVKIT was broken/blank. None of the demos were working.
It turns out that the driver simply did not initialize the vddioh member of an internal struct describing the SPI pins, so it was initialized to a random undefined value and optimized out by the compiler. The SPI pins then got initialized to 1.8V instead of 3.3V.
After this fix, all the TFT-based demos should be working again.
Checklist Before Requesting Review