iio: iio_app: simplify uart print + don't overwrite status-code in iio_app_init() on the error path #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status code on the error path is pretty useful. Don't overwrite it. Signed-off-by: Alexandru Ardelean <aardelean@baylibre.com>
For one thing, printing any message with 'iio_print_uart_info_message()' will needlessly reset the already initialized uart_desc object. Then the delay for the xfer rate seems un-needed. The 'no_os_uart_write()' should handle all this properly. Signed-off-by: Alexandru Ardelean <aardelean@baylibre.com>
commodo
requested review from
buha,
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
buha
reviewed
Oct 4, 2024
| no_os_mdelay(delay_ms); | ||
|
|
||
| /** Reinitialize UART with parameters required by the IIO application */ | ||
| no_os_uart_remove(*uart_desc); |
There was a problem hiding this comment.
IIRC this was needed and is still needed because there is no API to change baudrate once the UART was initialized. And sometimes the iiod runs at higher baudrate than the iio greeting message. I think adding an UART baudrate change API would be the proper way to address this mess.
And because there was no API, we had to "needlessly" _remove() and _init() with a delay in between because on fast processors or slow UARTs or both, you'd see a partial iio greeting message.
There was a problem hiding this comment.
so, if that's the case then i'd need to re-visit this
because the no_os_uart_remove() + no_os_uart_init() doesn't seem to initialize properly;
some init_data gets lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Two changes done during the development of the
ad7606x-fmcprojectPR Type
PR Checklist