Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change password #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

braidsencurls
Copy link

No description provided.

@anantjain6
Copy link
Owner

@braidsencurls Thanks for your contribution

I have the following comments:-

  1. "Password" can not be model as per MVC architecture
  2. In "change-password.jsp" for new password, you have instructed that it should contain an upper case and a lower case, but as per your code, it should contain a digit/numeric also.
  3. On entering the wrong old password you are showing error message "Error changing Password" which don't describe the user about the mistake he/she has done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants