fix: improve groupid extraction for Jenkins plugins #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonsteimel
force-pushed
the
consider-group-id-manifest-property-for-jenkins-plugins
branch
3 times, most recently
from
669e43f
to
1cc40a1
Compare
|
@westonsteimel was there anything else you wanted to do for this PR? If you want to sync tomorrow morning or next time your free we could write down what's left and I could try and help get this across the finish line? I didn't see anywhere if there was another fix besides the |
spiffcs
previously approved these changes
Jun 5, 2024
Consider the `Group-Id` java manifest property as this is typically set for Jenkins plugins if there is no pom file Signed-off-by: Weston Steimel <commits@weston.slmail.me>
westonsteimel
force-pushed
the
consider-group-id-manifest-property-for-jenkins-plugins
branch
from
1cc40a1
to
386f3fe
Compare
|
@spiffcs , sorry I missed your comment and I had completely forgotten about this one. I think all that was missing is adding some jenkins plugins into the integration test image |
|
Oh, we also need some unit tests for the package type logic (changing the type from being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the
Group-Idjava manifest property as this is typically set for Jenkins plugins if there is no pom file