Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YT Music - Translations): Update Korean #486

Closed
wants to merge 1 commit into from

Conversation

zerozero0022
Copy link
Contributor

feat(YT Music - Translations): Update Korean

@anddea
Copy link
Owner

anddea commented May 18, 2024

If you contribute to inotia's crowdin and once he adds translations to his repository, they will be translated here too automatically. Unless automated script will give some unknown error and skip.

@zerozero0022
Copy link
Contributor Author

zerozero0022 commented May 20, 2024

@anddea

Your RVX Music doesn't need to be translated by me because you'll get the translation files from the inotia github, right?

And your RVX has a String with a different name than inotia's RVX and has its own features, so do I need to translate it separately?

I made some changes to inotia's RVX translation file over the weekend, do I need to make changes to yours?

@anddea
Copy link
Owner

anddea commented May 20, 2024

No, only unique strings. They should be in missing strings file but there can be some strings from crowdin just by an accident, so if you already translated those exact keys then just delete them, they will be automatically merged from crowdin.

@zerozero0022
Copy link
Contributor Author

zerozero0022 commented May 22, 2024

feat(YouTube - Settings): Add search bar for settings ( 85cf0c0 )

I can't request for this setting to inotia because I think it's something you'll be upset about because you're the developer of this setting.

I'm sorry, but could you please request for this setting you made to inotia?

@anddea
Copy link
Owner

anddea commented May 22, 2024

you'll be upset about

Why should I be? I don't think he accepts feature requests for YouTube though.

feat(YouTube - Settings): Add search bar for settings

Why do you need it there if you have it here? Eventually, I'm going to open PRs for all unique features from this repo, so our repos are synced. Search needs more polishing but I got very busy lately. If @inotia00 is ready to accept as it is right now and if he has time to polish it, then I can open PR right away.

@inotia00
Copy link
Contributor

nvm I'm just busy right now so I can't merge the commits, but I'll process them all after the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants