Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft allocate checks owner #158174595 #31

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

matthewacha
Copy link
Contributor

@matthewacha matthewacha commented Jul 17, 2018

Status

IN DEVELOPMENT

Migrations

YES

Description

Team access should not guarantee all existing individual healthchecks jobs access. A user granting team access to their account should be able to assign different jobs to the person they are granting access to.

Related PRs

List related PRs against other branches:

Todos

  • Tests
  • api/models
  • form
  • UI

Deploy Notes

  • Migrations have been made, so ensure to run ./manage.py migrate
  • set environment viriables

Steps to Test or Reproduce

git pull origin ft-allocate-checks-owner-#158174595
git checkout ft-allocate-checks-owner-#158174595
./manage.py test hc.api.tests.test_sendalerts_to_owner

Impacted Areas in Application

  • api/tests/test_sendalerts.py
  • api/tests/test_protocol.py
  • models.py

  - add check_owner column
  - send alert to check owner
  - run makemigrations
[Delivers #158174595]
  - add check_owner column
  - send alert to check owner
  - run makemigrations
[Delivers #158174595]
@magicmarie magicmarie temporarily deployed to health-checks-aces-stagi-pr-31 July 17, 2018 14:45 Inactive
@coveralls
Copy link

Pull Request Test Coverage Report for Build 439

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 83.42%

Totals Coverage Status
Change from base Build 420: 0.2%
Covered Lines: 1917
Relevant Lines: 2298

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 17, 2018

Pull Request Test Coverage Report for Build 445

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 83.42%

Totals Coverage Status
Change from base Build 420: 0.2%
Covered Lines: 1917
Relevant Lines: 2298

💛 - Coveralls

@matthewacha matthewacha temporarily deployed to health-checks-aces-stagi-pr-31 July 17, 2018 16:48 Inactive
@matthewacha matthewacha temporarily deployed to health-checks-aces-stagi-pr-31 July 19, 2018 07:07 Inactive
  - add check_owner column
  - send alert to check owner
  - run makemigrations
[Delivers #158174595]
  - add check_owner column
  - send alert to check owner
  - run makemigrations
[Delivers #158174595]
-add update owner in ui
@matthewacha matthewacha temporarily deployed to health-checks-aces-stagi-pr-31 July 19, 2018 07:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants