-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft allocate checks owner #158174595 #31
Open
matthewacha
wants to merge
12
commits into
develop
Choose a base branch
from
ft-allocate-checks-owner-#158174595
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add check_owner column - send alert to check owner - run makemigrations [Delivers #158174595]
- add check_owner column - send alert to check owner - run makemigrations [Delivers #158174595]
…com/andela/hc-aces-kla into ft-allocate-checks-owner-#158174595
Pull Request Test Coverage Report for Build 439
💛 - Coveralls |
Pull Request Test Coverage Report for Build 445
💛 - Coveralls |
- add check_owner column - send alert to check owner - run makemigrations [Delivers #158174595]
- add check_owner column - send alert to check owner - run makemigrations [Delivers #158174595]
-add update owner in ui
…com/andela/hc-aces-kla into ft-allocate-checks-owner-#158174595
…com/andela/hc-aces-kla into ft-allocate-checks-owner-#158174595
…com/andela/hc-aces-kla into ft-allocate-checks-owner-#158174595
matthewacha
added
good first issue
Good for newcomers
ready-for-review
and removed
good first issue
Good for newcomers
labels
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
IN DEVELOPMENT
Migrations
YES
Description
Team access should not guarantee all existing individual healthchecks jobs access. A user granting team access to their account should be able to assign different jobs to the person they are granting access to.
Related PRs
List related PRs against other branches:
Todos
Deploy Notes
./manage.py migrate
Steps to Test or Reproduce
git pull origin ft-allocate-checks-owner-#158174595 git checkout ft-allocate-checks-owner-#158174595 ./manage.py test hc.api.tests.test_sendalerts_to_owner
Impacted Areas in Application